This repository was archived by the owner on Jul 6, 2026. It is now read-only.
fix duplicate setter methods#1322
Merged
Merged
Conversation
weidongxu-microsoft
left a comment
weidongxu-microsoft
left a comment
Member
There was a problem hiding this comment.
clean-up file not related to your change
XiaofeiCao
marked this pull request as ready for review
January 20, 2022 09:12
| Assertions.assertEquals(toOverride.size(), 1); | ||
| } | ||
|
|
||
| private ObjectSchema loadSiteSchemaParent() { |
Member
There was a problem hiding this comment.
why called loadSiteSchemaParent?
Member
There was a problem hiding this comment.
just loadSiteSchema?
Contributor
Author
There was a problem hiding this comment.
I haven't look much deep into it, but when I tried to load the child schema Site only, This line of code :
will get null for parent model, so I choose to load parent schema, which will have this line of code:
run and register the parent model.
Contributor
Author
There was a problem hiding this comment.
Changed to load full code model.
weidongxu-microsoft
approved these changes
Jan 21, 2022
weidongxu-microsoft
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1320